fix: updates GitHub Actions runner image and restart policy #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest version of the runner has podman v4 which is needed for compatibilty with the version of docker
Restarting trestlebot containers cfreate unexpected behavior because of the shared volume. For this use case, it should be never. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
gvauter
requested changes
Jul 5, 2024
| try: | ||
| clean(tmpdir, repo) | ||
| except Exception as e: | ||
| logging.error(f"Failed to clean up temporary git repository: {e}") |
There was a problem hiding this comment.
@jpower432 should this use a logger instance vs logging?
There was a problem hiding this comment.
Thanks for pointing this out. I think the logging statement should be removed here. It was left in for temporary debugging for an issue that this change resolves.
The logging statement was for debugging and should be removed to ensure resource cleanup errors are properly logged Signed-off-by: Jennifer Power <[email protected]>
|
@gvauter PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
podmanwhich is compatible with version of Docker (Note - this public beta slated to go GA in Sept)Rationale
Why use
podmananddocker?They are used in different contexts.
podmanis used to manage containers in E2E testing.dockerGitHub Actions are used for image building in the release pipeline.podmanpods is required to run the mock server and trestle-bot on the same network stack. It is also what the team is more familiar with.imagebuilding in GitHub Actions, thedockeractions have the features we need for image tag management and caching.Alternatives
ubuntu-latest. This is possible through brew or manually, but we would need to back out the changes in Sept.Fixes #251
Type of change
How has this been tested?
Checklist