Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump trestle to version v3.3.0 #269

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Jul 17, 2024

Description

Bump trestle version to v3
trestle v3 is using pydantic v2 with the v1 interface. Since our pydantic use is localized to TrestleRule I made updates for v2.

Fixes #241

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • E2E tests
  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 marked this pull request as draft July 17, 2024 20:33
Applys changes neccessary to upgrade to
compliance-trestle v3 and pydantic v2

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review July 19, 2024 17:10
@jpower432 jpower432 requested a review from a team July 19, 2024 17:11
Copy link
Contributor

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit a2a2db6 into main Jul 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trestle-bot to use the latest version of compliance-trestle
2 participants