Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add markdown-include package to workflow and poetry #339

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

gvauter
Copy link
Contributor

@gvauter gvauter commented Sep 3, 2024

Description

Adds the markdown-include package to the publish-docs GitHub workflow and poetry dev group.

Fixes #338

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Ran poetry install --with dev localy

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gvauter gvauter linked an issue Sep 3, 2024 that may be closed by this pull request
@gvauter gvauter changed the title ci (fix): add markdown-include package to workflow and poetry fix(ci): add markdown-include package to workflow and poetry Sep 3, 2024
@gvauter gvauter changed the title fix(ci): add markdown-include package to workflow and poetry fix: add markdown-include package to workflow and poetry Sep 3, 2024
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvauter gvauter merged commit c7a05ee into main Sep 3, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for publish-docs is missing markdown-include package
2 participants