-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removes provider from init and moves CI templates #344
Conversation
…iles Signed-off-by: Jennifer Power <[email protected]>
To simplfy this feature, the provider workflows will be available in the repo under TEMPLATES to copy manually. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
**For example Component Definition authoring in GitHub Actions** | ||
``` | ||
cp TEMPLATES/github/trestlebot-create-component-definition.yml .github/workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .github dir won't be generated after the trestlebot init and has been removed on line 53. So .github needs to be created manually. Is that the expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The .github/workflows
directory would need to be created. Thanks for pointing that out. I could include a mkdir
line.
The job failed after copying the workflow .github/workflows/trestlebot-rules-transform.yml. More details: https://github.com/huiwangredhat/trestlebot-demo3/actions/runs/10842292114(I guess it should be contents: write). The workflow files are allowed to be updated by the end users according to the requirements, am I right? |
You are right! Thank you finding this issue. |
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply. LGTM.
Description
This moves the CI templates out from the
trestle-bot
packages and allows users to copy them fromTEMPLATES
Fixes #343
Type of change
How has this been tested?
Checklist