docs: adr-001 cli implementation #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvauter
added
enhancement
gvauter
changed the title
jpower432
reviewed
Sep 18, 2024
| --- | ||
| x-trestle-template-version: 0.0.1 | ||
| title: Implement CLI Framework | ||
| status: accespted |
There was a problem hiding this comment.
Suggested change
| status: accespted | |
| status: accepted |
| markdown-path-catalog: markdown/catalogs | ||
| markdown-path-compdef: markdown/component-definitions | ||
| ssp-index-path: ssp-index.json | ||
| profile-upstreams: [<url>] |
There was a problem hiding this comment.
This would be to support the sync-upstreams command, correct? I think we could collapse this to a single field given that trestle would import the upstream artifacts into the correct location based on model type.
| git-committer-email: [email protected] | ||
| models: | ||
| # we could allow for multiple or keep this as one | ||
| - oscal-model: "ssp" |
There was a problem hiding this comment.
This configuration would be per model type so I think markdown-path makes more sense here. As well as ssp-index. My line of thinking is if you need to specify a model type on the field, it should go under the model specific configuration. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ADR for proposed Click CLI and config file implementation.