Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): adds compliance-trestle-fedramp dependency #349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(deps): adds compliance-trestle-fedramp dependency #349

wants to merge 2 commits into from

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Sep 19, 2024 •
edited
Loading

Description

Adds the compliance-trestle-fedramp as an optional dependency so that the version included with trestle-bot will be resolved with the version of compliance-trestle being leveraged to ensure compatibility.

Fixes #318

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

https://github.com/RedHatProductSecurity/trestle-bot/actions/runs/10948934460

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
chore(deps): adds compliance-trestle-fedramp dependency
98bd9bc 
Adds the compliance-trestle-fedramp as an optional dependency so
that the version included with trestle-bot will be resolved with
the version of compliance-trestle being leveraged to ensure compatibility.

Refs: PSCE-578
Closes: #318

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review September 19, 2024 21:28
gvauter
gvauter approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/ poetry locally, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvauter gvauter gvauter approved these changes

@d10n d10n Awaiting requested review from d10n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate FedRAMP plugin into docker file
2 participants
@jpower432 @gvauter