Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bot): change for configuring trestle-bot PR body update #363

Conversation

hbraswelrh
Copy link
Contributor

@hbraswelrh hbraswelrh commented Oct 9, 2024

Description

The changes made allow the body of the pull request submitted by trestle-bot to be configured as "Authored by trestle-bot." The changed parameter allows for configuring the PR submitted by trestle-bot to provide additional context for the user. The Makefile develop test case change allows for proper local working privileges.

Closes #320

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • The commands make test and make develop were run on the command line to validate the test cases.
  • Tests run using poetry were performed using poetry install --with tests,dev on the command line. The Makefile has the matching make develop poetry install --with tests,dev command. The Semgrep tests were used for checking pre-commit.

Test Configuration:

  • Firmware version: N/A
  • Hardware: Lenovo ThinkPad P1 Gen 4i
  • Toolchain: N/A
  • SDK: N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hbraswelrh hbraswelrh changed the title Changes made for Issue #320 PR body. Updated bug in Makefile pre-commit fix: trestle-bot issue #320 PR body. Updated bug in Makefile pre-commit Oct 9, 2024
@hbraswelrh hbraswelrh changed the title fix: trestle-bot issue #320 PR body. Updated bug in Makefile pre-commit fix: trestle-bot PR body update and testing command revision Oct 10, 2024
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbraswelrh hbraswelrh force-pushed the 320-add-information-to-the-pr-body-submitted-by-trestle-bot branch from d1827aa to 72e2a03 Compare October 11, 2024 20:16
@hbraswelrh hbraswelrh changed the title fix: trestle-bot PR body update and testing command revision feat(bot): change for configuring trestle-bot PR body update Oct 11, 2024
@jpower432 jpower432 merged commit 812ae9a into RedHatProductSecurity:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information to the PR body submitted by trestle-bot
2 participants