Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSCE-239: feat: adds validation for YAML trestle rules #52

Merged
merged 3 commits into from
Oct 12, 2023
Merged

PSCE-239: feat: adds validation for YAML trestle rules #52

merged 3 commits into from
Oct 12, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 4, 2023 •
edited
Loading

Description

Adds basic validation implementation which allows for additional validation on top of pydantic.

  • The added validation currently checks that the parameter and alternatives values are structured correctly

Some Ideas for future validation

  • Check that the profiles referenced are accessible.

Blocked #50

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title feat: adds validation for YAML trestle rules PSCE-239: feat: adds validation for YAML trestle rules Oct 4, 2023
@jpower432 jpower432 requested a review from afflom October 10, 2023 17:27
@jpower432 jpower432 marked this pull request as draft October 11, 2023 16:38
@jpower432
feat(transformers): initial validation handler from pre-validation be…
8d28bb7 
…fore pydantic

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
chore: fixes spelling error on csv_transformer.py comment
d9ed863 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432
feat(task): adds collection of validation errors in rules task
480e523 
Updates the rules transform task to make sure all errors for a
component defintion are collection during transformation and presented
back to the user to make errors easier to address at one time.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 11, 2023 17:32
@afflom afflom merged commit 11a1a7c into RedHatProductSecurity:main Oct 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflom afflom afflom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @afflom