Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCE-243 #53

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,8 @@ cat my-token.txt | podman secret create repo-secret -

```bash
podman run --entrypoint /entrypoint.sh --secret repo-secret,type=env,target=GITHUB_TOKEN --env-file=envfile -v my-trestle-space:/data -w /data localhost:5000/trestlebot:latest
```
```

### Adding a new action

First, create an entrypoint script for the new action in the `trestlebot/infra` directory. Then add the action by creating a new directory in the `actions` directory with an `action.yml` that references your new entrypoint.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ RUN microdnf install -y git \
&& microdnf clean all \
&& rm -rf /var/lib/apt/lists/*

COPY ./entrypoint.sh /
COPY ./trestlebot/infra/entrypoints/* /entrypoints/

RUN chmod +x /entrypoint.sh
RUN for f in /entrypoints/*; do chmod +x $f; done

ENTRYPOINT ["python3.9", "-m" , "trestlebot"]
CMD ["--help"]
Expand Down
2 changes: 1 addition & 1 deletion action.yml → actions/trestle-bot/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ outputs:

runs:
using: "docker"
image: "Dockerfile"
image: "quay.io/continuouscompliance/trestlebot:latest"
Copy link
Member

@jpower432 jpower432 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we point to the pre-built image, I would prefer we not point to latest. Pointing to latest means that older versions of the trestlebot action could be pointing to the newest image and breaking changes could make older version of the action unusable (i.e. inputs are expected, but not provided in the action.yml)

entrypoint: "/entrypoint.sh"
env:
GITHUB_TOKEN: ${{ inputs.github_token }}
Expand Down
File renamed without changes.
Loading