Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCE-249 - Add entrypoint for trestle YAML rule transformation #55

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 9, 2023

Description

Adds rules transform entrypoint

  • Updates CONTRIBUTING.md with updated components and code information
  • Adds trestle rules transformation entrypoint script

Follow on work as discused with @afflom - convert the actions specific entrypoint wrappers to python.

Blocked by #53

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) - Updates the location of the actions in the repo

How has this been tested?

  • Unit test
  • Integration tests

Tests

Tested existing autosync workflow with new action location.
https://github.com/jpower432/cautious-potato/actions/runs/6486219931

Tested rules transform workflow
https://github.com/jpower432/cautious-potato/actions/runs/6486995566

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
Copy link
Member Author

@afflom I can break this down into multiple PRs if needed. The addition of the new entrypoint needed some restructuring and there is some cleanup of the test code in this PR.

@jpower432
Copy link
Member Author

@afflom I moved the generic test code changes/cleanup to a new PR - #56

@jpower432 jpower432 marked this pull request as ready for review October 11, 2023 20:12
@jpower432 jpower432 marked this pull request as draft October 12, 2023 20:25
@jpower432
Copy link
Member Author

Moved to draft while resolving conflicts.

afflom and others added 10 commits October 12, 2023 16:28
Related: PSCE-243
Signed-off-by: Alex Flom <[email protected]>
Moves cli.py and cli_base.py to entrypoint.py and entrypoint_base.py
Adds rules_transform.py to `infra/entrypoints`
Update CONTRIBUTING.md, pyproject.toml, and __main__.py with new name

Signed-off-by: Jennifer Power <[email protected]>
Moves autosync entrypoint to entrypoints directory
Removes infra directory

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 12, 2023 20:57
@jpower432 jpower432 requested a review from afflom October 12, 2023 20:57
@afflom afflom merged commit d60adda into RedHatProductSecurity:main Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants