Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCE-257: feat(authored): adds rules view creation for component definitions #59

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 14, 2023

Description

Moves YAMLBuilder to compdef.py and changes to RuleViewBuilder
Removes csv_to_yaml because the class/functions used from it have been removed
Adds minor changes in yaml transformer comments and test

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

BREAKING CHANGE: This changes the outcome of create_new_default method for component definitions from OSCAL JSON to the rules YAML.

How has this been tested?

  • Updates unit test
  • Functional Test (Follow on PR)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Moves YAMLBuilder to compdef.py and changes to RuleViewBuilder
Removes csv_to_yaml because the functions used from it have been removed
Adds minor changes in yaml transformer comments and test

BREAKING CHANGE: This changes the outcome of create_new_default
method for component definitions from OSCAL JSON to the rules YAML.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as draft October 14, 2023 00:39
@jpower432 jpower432 marked this pull request as ready for review October 16, 2023 13:27
@afflom afflom merged commit 8261e91 into RedHatProductSecurity:main Oct 16, 2023
7 checks passed
@jpower432 jpower432 deleted the PSCE-257 branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants