Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds reviewer checklist to PR template #75

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Nov 1, 2023

Description

Adds reviewer checklist

Type of change

  • This change requires a documentation update

How has this been tested?

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 requested a review from afflom November 1, 2023 22:45
@jpower432
Copy link
Member Author

jpower432 commented Nov 1, 2023

@afflom @beatrizmcouto This is still WIP, but hoping to use the PR as a jumping off point for us to collaborate on author and reviewer requirements before merge. Let me know what you think of the initial checklists.

@beatrizmcouto
Copy link
Contributor

LGTM. In terms of format it is very organized, in terms of content nothing stands out to be added or modified at the moment. Anything that needs to be record in JIRA or Confluence for the template?

@jpower432
Copy link
Member Author

LGTM. In terms of format it is very organized, in terms of content nothing stands out to be added or modified at the moment. Anything that needs to be record in JIRA or Confluence for the template?

Thanks @beatrizmcouto. I don't think we need to record anything separately. This should just apply to this repository.

@beatrizmcouto
Copy link
Contributor

@afflom before you joined the daily Jenn and I were discussing on creating a checklist of things to do for the person who is reviewing a PR and ensure we all agree on the approach. Could you review by the end of the week so that we can discuss any ideas as a team next week? I will add it to my to do list as well.

@jpower432 jpower432 closed this Dec 8, 2023
@jpower432 jpower432 deleted the chore/update-pr-template branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants