Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: adds test with RequestsMock for create_pull_request unit tests #99

Merged
merged 5 commits into from
Dec 8, 2023
Merged

tests: adds test with RequestsMock for create_pull_request unit tests #99

merged 5 commits into from
Dec 8, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Dec 7, 2023 •
edited
Loading

Description

Adds tests for create_pull_request for GitHub and GitLab provider types.

Type of change

  • Tests Only

How has this been tested?

  • Unit tests added with requests mocking

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
tests/trestlebot/test_github.py Fixed Show fixed Hide fixed
tests/trestlebot/test_github.py Fixed Show fixed Hide fixed
@jpower432 jpower432 marked this pull request as ready for review December 7, 2023 21:16
beatrizmcouto
beatrizmcouto approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during paired code review Dec 8

@jpower432 jpower432 merged commit 3f39772 into main Dec 8, 2023
16 checks passed
@jpower432 jpower432 deleted the PSCE-291 branch December 8, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto