Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

puppet done test should stop after some time #97

Open
pcfe opened this issue Oct 17, 2017 · 3 comments
Open

puppet done test should stop after some time #97

pcfe opened this issue Oct 17, 2017 · 3 comments

Comments

@pcfe
Copy link
Collaborator

pcfe commented Oct 17, 2017

currently the code does not have a timeout for running puppet-done-test.sh

Ideally we want to wait some maximum (e.g. 30 minutes) and then simply continue so that the test can fail instead of running indefinitely.

It should be sufficient to change the above line to /usr/bin/timeout 30m /root/puppet-done-test.sh

@pcfe pcfe self-assigned this Oct 17, 2017
@pcfe
Copy link
Collaborator Author

pcfe commented Oct 17, 2017

note to self: the above suggestion is now active at $current_customer. If it works for a couple days then I'll implement it here too.

@pcfe
Copy link
Collaborator Author

pcfe commented Oct 17, 2017

note2 to self:
well not quite, while it kills the script puppet-done-test.sh, the build continues, so make something that also makes the build fail immediately after the timeout

pcfe added a commit that referenced this issue Oct 18, 2017
- should fix Issue #97
- working fine when tested at $current_customer
@pcfe
Copy link
Collaborator Author

pcfe commented Oct 18, 2017

notes:

  • 9bcc45f is not yet perfect as the exit 1 does not end up making the build fail.
  • it does address the problem of never ending wait on puppet though which was my main concern,
  • if a puppet run did not finish, the tests will fail, so maybe we can just use 9bcc45f
  • comments welcome.

pcfe added a commit that referenced this issue Oct 22, 2017
- should fix Issue #97
- working fine when tested at $current_customer
nstrug pushed a commit that referenced this issue Aug 16, 2019
* Introdcue pipeline as code

* adjusted copy of buildtestvms.sh

* introduce sleep flag to puppet-done-test.sh

* added one forced puppet run before we start waiting

* remove workspace cleanup plugin specific step and use deleteDir instead

* disable systemd-nspawn in mock. Fixes #74

* Cleanups 20170914 (#78)

* info -> inform

info is a shell command, so switch to infrom as function name
for printing info.

* first version of capsule sync check

* explain why pushtests.sh can take a long time

* remove superfuous spaces in README.md

* fix typo in variable name

* echo before sleep when poking SUT

* fixup, had one inform line twice

* wait for both ContentView and Repository syncs

* Issue 87 (#89)

* remove note to disable SELinux. Closes #87

* fixup, typo

* fixes #25

* use capsule-sync-check.sh in Jenkinsfile

* introduce timeouts for puppet-done-test

- should fix Issue #97
- working fine when tested at $current_customer

* Wait for build of test VMs to end (#96)

* make buildtestvms.sh wait for SUT to exit build state

* sleep 10 -> 15 and shorted log output

* only check every minute on an installing VM

* fixup: typo

* split up prep and test stages

* add config option for rhel version

* rename from elX to rhel-x, add documentation for pipeline in general

* fixed typo in markdown

* rhel-version param is defined in pipeline job, removed param from config.xml for polling job

* minor corrections after proofreading

* Issue 106: Always display all stages in jenkins' (classic) stage view

* fixed typo

* Satellite 6.3 fixed Bug 1417976 remove Sat 6.2 work-around in buildtestvms.sh

* adjust hammer command for Sat 6.3.2

* fixup, clarify log message

* minor documentation fix

* fixed markdown and adjusted headers

* add lost statement that the jenkins user has to own the job config file

* forgotten info -> infrom fixed in two files

* use the intended CV for pipeline job

* Sat 6.3, 6.4 and 6.5 added to readme

* new path for hammer CLI config

* adjust install guide link to Sat 6.5 one

* link to latest hammer cli config docs

* allow promote environment out of sequence
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant