Respect symlinks when reading static mocks #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Ignition
requested review from
Alexander-Ignition,
modestman and
subdan
| if fileExists(atPath: symLinkDestination) { | ||
| return symLinkDestination | ||
| } | ||
| let basePath = (path as NSString).deletingLastPathComponent as NSString |
There was a problem hiding this comment.
I didn't understand why the last component of the path is being removed
subdan
reviewed
Nov 9, 2021
Comment on lines
78
to
79
| let basePath = (path as NSString).deletingLastPathComponent as NSString | ||
| let symlinkFullPath = basePath.appendingPathComponent(symLinkDestination) |
There was a problem hiding this comment.
Could you please explain why do we need these lines of code?
There was a problem hiding this comment.
It is used when symlink contains relative link to another file. So we reconstruct full path from current symlink path + relative path from symlink
Alexander-Ignition
force-pushed
the
master
branch
from
4aa81cc to
b6455e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no option to save&repeat redirects in static mocks.
I suggested to make them with symbolic links from file to file.
The problem in current implementation that Vapor follows symlink when reading content of the file, but sets "content-length" header to symlink size. So, we always have incomplete response.
So I decided to check if the file is symlink and then follow it