fix: added condition to set the listing image caption #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wagner3UB
added
the
a11y-accessibility
|
Attenzione: il metadata image_caption ancora non viene passato dal BE correttamente. Sono in attesa per fare i test finale. |
giuliaghisini
requested changes
Jan 10, 2025
src/components/ItaliaTheme/Blocks/Listing/Commons/ListingImage.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/Listing/Commons/ListingImage.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/Listing/Commons/ListingImage.jsx
Outdated
Show resolved
Hide resolved
giuliaghisini
approved these changes
Jan 27, 2025
Co-authored-by: Giulia Ghisini <[email protected]>
pnicolli
requested changes
Jan 27, 2025
| //Verifies if the item has a preview image or an header image | ||
| const showTitleAttr = !!( | ||
| (item.hasPreviewImage && item.preview_caption) || | ||
| (item.image_field && item.image_caption) |
There was a problem hiding this comment.
Questo penso non si possa fare, la didascalia dell'immagine di testata viene usata nella view dei vari content-type come effettiva didascalia dell'immagine. Mi sta bene invece usare la didascalia dell'immagine di anteprima, se è compilata.
| const imageCaption = | ||
| item.hasPreviewImage && item.preview_caption | ||
| ? item.preview_caption | ||
| : item.image_field && item.image_caption |
There was a problem hiding this comment.
Vedi sopra, non userei image_caption
src/components/ItaliaTheme/Blocks/Listing/CompleteBlockLinksTemplate.jsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
US: https://redturtle.tpondemand.com/entity/62740-in-tutti-i-template-del-blocco
Aggiunta logica per la corretta assegnazione degli attributi alt e title nelle immagini dei blocchi listing
È importante mantenere le richieste anteriore create per Parma - l'immagine non può contenere title="" se alt="" è vuoto:
us: https://redturtle.tpondemand.com/entity/50642-rimuovere-title-da-immagine-della-card
pr: #558