Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update summary serializer for geolocation information #213

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

luca-bellenghi
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6930645958

  • 14 of 19 (73.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 74.843%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/design/plone/contenttypes/restapi/serializers/summary.py 14 19 73.68%
Totals Coverage Status
Change from base Build 6785770726: -0.01%
Covered Lines: 3100
Relevant Lines: 4142

💛 - Coveralls

@luca-bellenghi luca-bellenghi requested a review from cekk November 20, 2023 12:27
@luca-bellenghi luca-bellenghi marked this pull request as ready for review November 20, 2023 12:27
@luca-bellenghi
Copy link
Member Author

@cekk questa è una prima parte. una parte del bug è dentro redturtle.volto, ma li voglio andare più cauto. parto con una monkey patch su un cliente e questa versione di design.plone.contenttypes. se funziona ti mostro come cambierei redturtle.volto.
Questa fix, da sola, non da problemi: non sono bug dipendenti l'uno dall'altro e qui, alla peggio, do più occasioni rispetto a prima di ottenere informazioni nel json di risposta.

@mamico
Copy link
Contributor

mamico commented Nov 20, 2023

manca changelog

@cekk cekk merged commit 19e15f9 into main Nov 21, 2023
9 checks passed
@cekk cekk deleted the bug_47428_variazione_mappa_blocco_elenco branch November 21, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants