Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Us 57885 fix rss feed for volto #112

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

luca-bellenghi
Copy link
Member

We need to override collection serializer due to redturtle.volto summary serializer customization: when try to get_remote_url for links, we run into a AttributeError trying to get the plone_portal_state from the link collection result.

@luca-bellenghi luca-bellenghi merged commit 2492385 into master Aug 23, 2024
20 checks passed
@luca-bellenghi luca-bellenghi deleted the us_57885_fix_rss_feed_for_volto branch August 23, 2024 11:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10524127673

Details

  • 27 of 29 (93.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 66.755%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/volto/restapi/serializer/collection.py 27 29 93.1%
Totals Coverage Status
Change from base Build 10349346799: 0.8%
Covered Lines: 1004
Relevant Lines: 1504

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants