Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid searching all users when many_users is flagged #75

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Sep 22, 2023

@mamico mamico requested a review from cekk September 22, 2023 13:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6275050399

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 62.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/volto/monkey.py 1 6 16.67%
Totals Coverage Status
Change from base Build 6262756817: -0.2%
Covered Lines: 758
Relevant Lines: 1207

💛 - Coveralls

@luca-bellenghi
Copy link
Member

@mamico in realtà a me da problemi. su comune di P. dove lo dovevo provare

Traceback (innermost last):
Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents
Module ZPublisher.WSGIPublisher, line 390, in publish_module
Module ZPublisher.WSGIPublisher, line 285, in publish
Module ZPublisher.mapply, line 85, in mapply
Module ZPublisher.WSGIPublisher, line 68, in call_object
Module Products.CMFPlone.controlpanel.browser.usergroups_groupmembership, line 84, in call
Module Products.CMFPlone.controlpanel.browser.usergroups_groupmembership, line 75, in update
Module redturtle.volto.monkey, line 133, in getPotentialMembers
AttributeError: 'SimpleViewClass from /opt/iocomune.buildout/co' object has no attribute '_old__getPotentialMembers'

@mamico
Copy link
Contributor Author

mamico commented Sep 26, 2023

@mamico in realtà a me da problemi. su comune di P. dove lo dovevo provare
...

Module redturtle.volto.monkey, line 133, in getPotentialMembers
AttributeError: 'SimpleViewClass from /opt/iocomune.buildout/co' object has no attribute '_old__getPotentialMembers'

probabilmente era questo: 384c086

Copy link
Member

@luca-bellenghi luca-bellenghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dai test fatti mi pare tutto in ordine

@mamico mamico merged commit 2e20bf0 into master Sep 26, 2023
16 checks passed
@mamico mamico deleted the cmfplone_3845_backport branch September 26, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants