Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error instead of raise Exception for BadRequest in querystringsearch #84

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Return error instead of raise Exception for BadRequest in querystringsearch #84

merged 1 commit into from
Nov 7, 2023

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Nov 7, 2023

No description provided.

@mamico mamico requested review from folix-01 and cekk November 7, 2023 09:21
@mamico mamico changed the title Return error instead of raise Excpetion for BadRequest in querystringsearch Return error instead of raise Exception for BadRequest in querystringsearch Nov 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6782408496

  • 2 of 8 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 63.1%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/volto/restapi/services/querystringsearch/get.py 2 8 25.0%
Totals Coverage Status
Change from base Build 6770625568: -0.1%
Covered Lines: 802
Relevant Lines: 1271
💛 - Coveralls

@cekk cekk merged commit 301b1ab into master Nov 7, 2023
17 checks passed
@cekk cekk deleted the bad_request branch November 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cekk cekk cekk approved these changes

@folix-01 folix-01 folix-01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mamico @coveralls @cekk @folix-01