Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to convert strings in internal paths for *form* blocks #97

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Mar 11, 2024

This could generate some problems for example when adding a field with options, and one option have the same name as a content id..we don't want to convert it into an internal path.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8233450572

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.953%

Totals Coverage Status
Change from base Build 8231419485: 0.0%
Covered Lines: 864
Relevant Lines: 1351

💛 - Coveralls

@luca-bellenghi luca-bellenghi merged commit 7ee3896 into master Mar 19, 2024
17 checks passed
@luca-bellenghi luca-bellenghi deleted the exclude_form_blocks_conversion branch March 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants