[In-Progress] Added multi-tenant dataset (early stages) #83

filipecosta90 · 2023-01-24T23:44:27Z

No description provided.

sonatype-lift · 2023-01-24T23:48:21Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    doc_ids = []
+
+    create_idxs_csvfile = open(create_idxs_fname, "w", newline="")
+    create_idxs_csv_writer = csv.writer(create_idxs_csvfile, delimiter=",")


Incompatible parameter type: Expected _csv._Writer for 1st positional only parameter to call _csv.writer but got io.TextIOWrapper.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-24T23:48:23Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    create_idxs_csv_writer = csv.writer(create_idxs_csvfile, delimiter=",")
+
+    setup_fname_csvfile = open(setup_fname, "w", newline="")
+    setup_csv_writer = csv.writer(setup_fname_csvfile, delimiter=",")


Incompatible parameter type: Expected _csv._Writer for 1st positional only parameter to call _csv.writer but got io.TextIOWrapper.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-24T23:48:25Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    doc_ids = []
+
+    create_idxs_csvfile = open(create_idxs_fname, "w", newline="")
+    create_idxs_csv_writer = csv.writer(create_idxs_csvfile, delimiter=",")


opt.semgrep.python.lang.security.unquoted-csv-writer.unquoted-csv-writer: Found an unquoted CSV writer. This is susceptible to injection. Use quoting=csv.QUOTE_ALL.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-24T23:48:27Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    create_idxs_csv_writer = csv.writer(create_idxs_csvfile, delimiter=",")
+
+    setup_fname_csvfile = open(setup_fname, "w", newline="")
+    setup_csv_writer = csv.writer(setup_fname_csvfile, delimiter=",")


opt.semgrep.python.lang.security.unquoted-csv-writer.unquoted-csv-writer: Found an unquoted CSV writer. This is susceptible to injection. Use quoting=csv.QUOTE_ALL.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-24T23:48:29Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+
+def rand_str(minN, maxN):
+    return "".join(
+        random.choices(


💬 8 similar findings have been found in this PR

blacklist: Standard pseudo-random generators are not suitable for security/cryptographic purposes.

🔎 Expand here to view all instances of this finding

File Path Line Number

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 58

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 65

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 72

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 78

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 82

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 87

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 152

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py 384

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-25T17:19:58Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+
+        progress = tqdm(unit="docs", total=total_docs)
+        for doc_n in range(0, total_docs):
+            index_n = random.randint(1, index_limit_n)


blacklist: Standard pseudo-random generators are not suitable for security/cryptographic purposes.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-25T17:20:00Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    if args.generate_index_commands_only is False:
+
+        setup_fname_csvfile = open(setup_fname, "w", newline="")
+        setup_csv_writer = csv.writer(setup_fname_csvfile, delimiter=",")


Incompatible parameter type: Expected _csv._Writer for 1st positional only parameter to call _csv.writer but got io.TextIOWrapper.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-25T17:20:02Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+        progress.close()
+        setup_fname_csvfile.close()
+
+        artifacts.append(setup_fname_csvfile)


Incompatible parameter type: Expected str for 1st positional only parameter to call list.append but got io.TextIOWrapper.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-25T17:20:05Z

scripts/datagen_redisearch/search_multi_tenant/ftsb_generate_search_multi_tenant.py

+    if args.generate_index_commands_only is False:
+
+        setup_fname_csvfile = open(setup_fname, "w", newline="")
+        setup_csv_writer = csv.writer(setup_fname_csvfile, delimiter=",")


opt.semgrep.python.lang.security.unquoted-csv-writer.unquoted-csv-writer: Found an unquoted CSV writer. This is susceptible to injection. Use quoting=csv.QUOTE_ALL.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonarqubecloud · 2023-01-25T21:32:22Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
9 Security Hotspots
12 Code Smells

No Coverage information
24.6% Duplication

Added multi-tenant dataset (early stages)

6e2b4a0

filipecosta90 added the enhancement New feature or request label Jan 24, 2023

filipecosta90 changed the title ~~Added multi-tenant dataset (early stages)~~ [In-Progress] Added multi-tenant dataset (early stages) Jan 24, 2023

sonatype-lift bot reviewed Jan 24, 2023

View reviewed changes

filipecosta90 added 3 commits January 25, 2023 16:55

Updated field generation in multi-tenant script

cf92b2c

Eased the index artifacts creation

81b0d9e

Fixed setup file upload to s3

710125d

sonatype-lift bot reviewed Jan 25, 2023

View reviewed changes

Fixed index start range

ad7d423

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[In-Progress] Added multi-tenant dataset (early stages) #83

[In-Progress] Added multi-tenant dataset (early stages) #83

filipecosta90 commented Jan 24, 2023

sonatype-lift bot Jan 24, 2023

sonatype-lift bot Jan 24, 2023

sonatype-lift bot Jan 24, 2023

sonatype-lift bot Jan 24, 2023

sonatype-lift bot Jan 24, 2023

sonatype-lift bot Jan 25, 2023

sonatype-lift bot Jan 25, 2023

sonatype-lift bot Jan 25, 2023

sonatype-lift bot Jan 25, 2023

sonarqubecloud bot commented Jan 25, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

[In-Progress] Added multi-tenant dataset (early stages) #83

Are you sure you want to change the base?

[In-Progress] Added multi-tenant dataset (early stages) #83

Conversation

filipecosta90 commented Jan 24, 2023

sonatype-lift bot Jan 24, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 24, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 24, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 24, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 24, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 25, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 25, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 25, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 25, 2023

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 25, 2023