-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code polish #27
base: master
Are you sure you want to change the base?
code polish #27
Conversation
dengliming
commented
Apr 17, 2021
- Use DataType.valueOf instead of DataType.getDataTypefromString
- Fix model test in windows
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 87.62% 87.73% +0.10%
==========================================
Files 12 12
Lines 598 587 -11
Branches 83 78 -5
==========================================
- Hits 524 515 -9
+ Misses 34 33 -1
+ Partials 40 39 -1
Continue to review full report at Codecov.
|
hi @dengliming |
@DvirDukhan yes. but I think these are low priority issues. We can ignore it for now. |
@gkorland Did you notice that thoretically it's a breaking change? |