Skip to content

Conversation

rawkode
Copy link
Collaborator

@rawkode rawkode commented Sep 17, 2025

Major improvements to the end-to-end testing infrastructure:

Testing Infrastructure:

  • Add automatic payment method ID fetching from RedisCloud API
  • Create templated test examples with dynamic payment method injection
  • Add cluster/test/setup.sh script for comprehensive test environment setup
  • Add datasource.yaml for dynamic value injection in tests
  • Support environment variable configuration via .envrc

Documentation Updates:

  • Restructure TESTING.md with clear quick-start instructions
  • Add comprehensive payment method configuration section
  • Document environment variable setup with .envrc.example
  • Update CI-TESTING.md to reflect current CI/CD workflows
  • Clean up references to removed scripts in all docs

Cleanup:

  • Remove obsolete scripts (quick-start.sh, setup-podman.sh, test-provider.sh)
  • Consolidate functionality into Makefile targets
  • Add proper .gitignore entries for test artifacts
  • Remove untracked files (provider-aws/, kubeconfig, etc.)

Developer Experience:

  • Add devenv.nix configuration for development environment
  • Add rediscloud-payment-methods and rediscloud-first-payment-method-id make targets
  • Improve error handling and user feedback in setup scripts
  • Simplify credential management with environment variables

This refactoring makes the e2e testing process more robust and user-friendly, particularly for testing Pro subscription features that require payment methods.

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 10:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR significantly improves the end-to-end testing infrastructure and developer experience for the RedisCloud Crossplane provider. It removes obsolete scripts in favor of standardized Makefile targets, adds automatic payment method ID fetching for Pro subscription testing, and provides comprehensive documentation updates.

Key changes:

  • Remove legacy testing scripts and consolidate functionality into Makefile targets
  • Add automatic payment method ID fetching from RedisCloud API for Pro subscription tests
  • Implement templated test examples with dynamic value injection via setup script
  • Restructure documentation with clear quick-start instructions and environment setup

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/test-provider.sh Removes 362-line legacy testing script
scripts/setup-podman.sh Removes obsolete podman setup script
scripts/quick-start.sh Removes quick-start wrapper script
cluster/test/setup.sh Adds comprehensive test environment setup with payment method ID fetching
cluster/test/examples/*.yaml.tmpl Adds templated test examples for dynamic value injection
Makefile Adds RedisCloud API integration targets and improves e2e testing
TESTING.md Major restructure with clear workflows and payment method configuration
.envrc.example Adds example environment configuration file
devenv.nix Adds crossplane-cli and gettext packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rawkode rawkode force-pushed the feat/improve-test-tooling branch from 29365bf to a925995 Compare September 17, 2025 13:16
@RedisLabs RedisLabs deleted a comment from Copilot AI Sep 17, 2025
@RedisLabs RedisLabs deleted a comment from Copilot AI Sep 17, 2025
@rawkode rawkode force-pushed the feat/improve-test-tooling branch 3 times, most recently from 4dabe80 to b8e226f Compare September 17, 2025 13:50
Major improvements to the end-to-end testing infrastructure:

Testing Infrastructure:
- Add automatic payment method ID fetching from RedisCloud API
- Create templated test examples with dynamic payment method injection
- Add cluster/test/setup.sh script for comprehensive test environment setup
- Add datasource.yaml for dynamic value injection in tests
- Support environment variable configuration via .envrc

Documentation Updates:
- Restructure TESTING.md with clear quick-start instructions
- Add comprehensive payment method configuration section
- Document environment variable setup with .envrc.example
- Update CI-TESTING.md to reflect current CI/CD workflows
- Clean up references to removed scripts in all docs

Cleanup:
- Remove obsolete scripts (quick-start.sh, setup-podman.sh, test-provider.sh)
- Consolidate functionality into Makefile targets
- Add proper .gitignore entries for test artifacts
- Remove untracked files (provider-aws/, kubeconfig, etc.)

Developer Experience:
- Add devenv.nix configuration for development environment
- Add rediscloud-payment-methods and rediscloud-first-payment-method-id make targets
- Improve error handling and user feedback in setup scripts
- Simplify credential management with environment variables

This refactoring makes the e2e testing process more robust and user-friendly,
particularly for testing Pro subscription features that require payment methods.
@rawkode rawkode force-pushed the feat/improve-test-tooling branch from b8e226f to f6b47c4 Compare September 25, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants