Skip to content

Commit

Permalink
Increased timeout and a double-check
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnSharpe committed Oct 30, 2023
1 parent 7001f04 commit 0bed05b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions provider/resource_rediscloud_acl_role.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ func resourceRedisCloudAclRoleCreate(ctx context.Context, d *schema.ResourceData
return diag.FromErr(err)
}

// Sometimes ACL Users and Roles flip between Active and Pending a few times.
// Sometimes ACL Users and Roles flip between Active and Pending a few times after creation/update.
// This delay gives the API a chance to settle
// TODO Ultimately this is an API problem
time.Sleep(5 * time.Second) //lintignore:R018
time.Sleep(10 * time.Second) //lintignore:R018

err = waitForAclRoleToBeActive(ctx, id, api)
if err != nil {
Expand Down Expand Up @@ -175,10 +175,10 @@ func resourceRedisCloudAclRoleUpdate(ctx context.Context, d *schema.ResourceData
return diag.FromErr(err)
}

// Sometimes ACL Users and Roles flip between Active and Pending a few times.
// Sometimes ACL Users and Roles flip between Active and Pending a few times after creation/update.
// This delay gives the API a chance to settle
// TODO Ultimately this is an API problem
time.Sleep(5 * time.Second) //lintignore:R018
time.Sleep(10 * time.Second) //lintignore:R018

err = waitForAclRoleToBeActive(ctx, id, api)
if err != nil {
Expand Down
8 changes: 4 additions & 4 deletions provider/resource_rediscloud_acl_user.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ func resourceRedisCloudAclUserCreate(ctx context.Context, d *schema.ResourceData
return diag.FromErr(err)
}

// Sometimes ACL Users and Roles flip between Active and Pending a few times.
// Sometimes ACL Users and Roles flip between Active and Pending a few times after creation/update.
// This delay gives the API a chance to settle
// TODO Ultimately this is an API problem
time.Sleep(5 * time.Second) //lintignore:R018
time.Sleep(10 * time.Second) //lintignore:R018

err = waitForAclUserToBeActive(ctx, id, api)
if err != nil {
Expand Down Expand Up @@ -147,10 +147,10 @@ func resourceRedisCloudAclUserUpdate(ctx context.Context, d *schema.ResourceData
return diag.FromErr(err)
}

// Sometimes ACL Users and Roles flip between Active and Pending a few times.
// Sometimes ACL Users and Roles flip between Active and Pending a few times after creation/update.
// This delay gives the API a chance to settle
// TODO Ultimately this is an API problem
time.Sleep(5 * time.Second) //lintignore:R018
time.Sleep(10 * time.Second) //lintignore:R018

err = waitForAclUserToBeActive(ctx, id, api)
if err != nil {
Expand Down

0 comments on commit 0bed05b

Please sign in to comment.