-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for showExtensions and $ref for Responses #1406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, the only question is if the test message is corret?
@@ -31,5 +31,12 @@ describe('Models', () => { | |||
const resp = new ResponseModel(parser, 'default', true, {}, opts); | |||
expect(resp.type).toEqual('error'); | |||
}); | |||
|
|||
test('should be error if showExtensions is true', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! I missed updating the first half. ;)
Thanks for your contribution. I will merge it after the release today so it will land into the next release. |
Thanks much, including for the tagging |
@RomanHotsiy - Please merge this when you get a chance to unblock #1434 and #1435 |
cc0c845
to
3c4ece9
Compare
4ea3dd1
to
b4f3f02
Compare
Hey @shelbys! I am very sorry for the 1-year delay! 🙈 We now have more resources and time to work on Redoc so this PR will be merged today. |
If you appreciate this contribution, please add a
hacktoberfest-accepted
Label to the PR, so it'll be tracked