Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: v1.0.0-beta.131 #1169

Merged
merged 5 commits into from
Jul 10, 2023
Merged

chore: v1.0.0-beta.131 #1169

merged 5 commits into from
Jul 10, 2023

Conversation

IgorKarpiuk
Copy link
Contributor

@IgorKarpiuk IgorKarpiuk commented Jul 10, 2023 •
edited
Loading

What/Why/How?

Release v1.0.0-beta.131:

Reference

Closes: #1159
Closes: #1146

Testing

⚠️ It is expected that smoke tests fail in Yarn environments (only in release MRs!) due to specific dependencies resolving in Yarn.

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Command Mean [s] Min [s] Max [s] Relative
REDOCLY_TELEMETRY=off redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.245 ± 0.027 1.207 1.308 1.00
REDOCLY_TELEMETRY=off redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.280 ± 0.038 1.235 1.359 1.03 ± 0.04

tatomyr
tatomyr reviewed Jul 10, 2023
View reviewed changes
docs/changelog.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 74.47% 3728/5006
🟡 Branches 65.44% 2064/3154
🟡 Functions 66.7% 619/928
🟡 Lines 74.56% 3478/4665

Test suite run success

616 tests passing in 89 suites.

Report generated by 🧪jest coverage report action from 5c389fd

@IgorKarpiuk IgorKarpiuk marked this pull request as ready for review July 10, 2023 13:08
@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner July 10, 2023 13:08
@IgorKarpiuk IgorKarpiuk self-assigned this Jul 10, 2023
@IgorKarpiuk IgorKarpiuk requested review from lornajane and a team July 10, 2023 13:09
lornajane
lornajane reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor points

docs/changelog.md Outdated Show resolved Hide resolved
docs/changelog.md Outdated Show resolved Hide resolved
@tatomyr tatomyr requested a review from lornajane July 10, 2023 13:57
@IgorKarpiuk IgorKarpiuk force-pushed the chore/v1.0.0-beta.131 branch from f987a8c to 1bb1558 Compare July 10, 2023 13:58
lornajane
lornajane approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny fix but it's good to go!

docs/changelog.md Outdated Show resolved Hide resolved
@IgorKarpiuk @lornajane
Update docs/changelog.md
5c389fd 
Co-authored-by: Lorna Jane Mitchell <[email protected]>
@IgorKarpiuk IgorKarpiuk merged commit 6fe8392 into main Jul 10, 2023
@IgorKarpiuk IgorKarpiuk deleted the chore/v1.0.0-beta.131 branch July 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@tatomyr tatomyr tatomyr approved these changes

Assignees

@IgorKarpiuk IgorKarpiuk

Labels
deploy_s3_sandbox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with version 1.0.0-beta.130 redocly/cli lint hangs for a while before exiting
3 participants
@IgorKarpiuk @lornajane @tatomyr