Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not update domain env variable from code #1423

Closed
wants to merge 1 commit into from

Conversation

IgorKarpiuk
Copy link
Contributor

What/Why/How?

Do not update REDOCLY-DOMAIN env variable from code, use static variable instead

Reference

Testing

Screenshots (optional)

Has code been changed?

  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@IgorKarpiuk IgorKarpiuk self-assigned this Feb 1, 2024
@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner February 1, 2024 14:05
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: e1249c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.117 ± 0.020 1.085 1.165 1.00 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.114 ± 0.023 1.086 1.155 1.00

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.1% 4304/5656
🟡 Branches 65.85% 2246/3411
🟡 Functions 68.81% 695/1010
🟡 Lines 76.31% 4048/5305
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.ts
65.71% 71.43% 75% 65.71%

Test suite run success

699 tests passing in 100 suites.

Report generated by 🧪jest coverage report action from e1249c2

@IgorKarpiuk
Copy link
Contributor Author

Should be fixed in #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant