-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix issues with https-agent-proxy for cli and openapi-core packages #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 169d259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success722 tests passing in 102 suites. Report generated by 🧪jest coverage report action from 169d259 |
tatomyr
changed the title
Fix issues with https-agent-proxy for cli and openapi-core packages
fix: fix issues with https-agent-proxy for cli and openapi-core packages
Mar 1, 2024
tatomyr
approved these changes
Mar 1, 2024
tatomyr
added a commit
that referenced
this pull request
Mar 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Adding https-proxy-agent package to fix issues with requests when using CLI behind proxy. Create better mechanism for handling
env.REDOCLY_DOMAIN
usage in few modules.Now if you need to run the CLI tool behind a proxy, you can use the HTTP_PROXY and HTTPS_PROXY environment variables to configure the proxy settings.
https-proxy-agent
package was used fornode-fetch
requests. Now we pass agent for everyfetchWithTimeout
request, as well as other regularfetch
request.This is a rollback of a rollback #1458
After encountering problems with some of the packages from
https-proxy-agent
dependencies, we had to ignore this package for browser environment, by modyfingpackages/core/package.json
like so:Reference
Resolves #1404
Fixes #529
Fixes #1146
Resolves #1433
Testing
Fixed unit tests. Tested with few CLI commands:
push
,lint
etc.Screenshots (optional)
n/a
Has code been changed?
Yes
Check yourself
Security