Merge commit godotengine/godot@d2ada64 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a flag to guard button_up and button_down events based on whether button_down has been previously emitted. Buttons now emit button_up signals if they have emitted button_down and subsequently lose focus, do not emit button_up if they gain focus while ui_accept is still pressed, and do not emit multiple up/down signals if multiple ui_accept keys are pressed simultaneously.
This new method allow you to get the line offset of the current selection (returns -1 if nothing is selected.) This is useful if you want to pop up a control or menu above the currently selected text. Previously there was no accurate way to get this information. The logic is moved from the implementation of `scroll_to_selection` verbatim, and that method has been adjusted to avoid repetition.
reimport_append is used by gltf_document, fbx_document and editor_import_plugin. The first two will never call it when importing == false. It's only the editor_import_plugin that should guard against that. https://docs.godotengine.org/en/stable/classes/class_editorimportplugin.html#class-editorimportplugin-method-append-import-external-resource The motivation of removing the check from gltf_document call path is to be able to test nested imports (texture embedded in gltf).
Blender imports will always start within `.godot/imported` folder because we first convert the .blend file to .gltf, store it in `.godot/imported` and run the import from there, so on-disk resources linked from .blend files end up with duplicate textures.
The old code fetched some data before the `EditorScenePostImportPlugin._pre_process` callback. While the callback could modify existing keys, this prevented users from adding new data on a fresh import. By fetching the keys after pre_process, this means users can consistently modify import options for nodes, meshes, materials and animations in a post-import plugin.
This PR updates the `DisplayServer::virtual_keyboard_get_height()` method to return 0 with a warning instead of throwing an error when the virtual keyboard is not supported.
Fixes edge case where `0` encoded as `uid://` instead of `uid://a`, and fixes the size of the temporary buffer storing encoded UID strings.
… similar unsafe `ptr()` uses).
…during initialization
Also future-proof entries to ensure size.
…opriate class icon for object in it. Handle do&undo for selection when reparenting
…onstantly_walking_into_rakes Make `PopupMenu/Panel` shadows properly visible again
Mention native file dialogs editor setting in EditorFileDialog description
Don't emit `text_changed` signal when clearing empty LineEdit
Fix folders uncollapsed after restart with filter
Add more menus support to EditorContextMenuPlugin
Rework dock layout management
Show "transparent background" texture only behind actual texture in `TexturePreview` class + add borders for readability
Force build editor with regex module, remove checking code
Add a supersampling option to LightmapGI
Assign new UID when duplicating file externally
Remember QuickOpenDialog history between sessions
Fix `has_font` and `has_font_size` always return true
Don't show "Drawing rect" when not actually drawing
…er-debug-tooltip Fix documentation tooltip over debug tooltip
Correct aspect ratio used in FSR2 calculations
Save instance and global uniform data in RenderingServerDummy
Cache value of Jolt Physics project setting `bounce_velocity_threshold`
Add missing cleanup of editor history & set appropriate class icon for object in it
Allow post-import plugins to modify `_subresources`
Update official export templates architecture list in docs
[Main] Fix missing performance data
mcdubhghlas
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.