-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Implement game module system more consistently #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating .gitignore file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
missiles.folder
andshields.folder
ConfigLoader.class
,FileManager.class
SetupUtil.class
[...]_lobby_[...]
to[...]_games_[...]
[...]_lobby_[...]
to[...]_games_[...]
%lobby_name%
to%game_name%
MissileWars/lobbies/lobby0.yml
toMissileWars/games/game0.yml
lobby: ...
part (see screenshot below)Wiki-Update
Change of the MW "Game Module System"
MissileWars has a kind of modular system internally:
One game has 1x lobby and several arenas in the form of one world each, whereby several lobbies can have the same arena.
With this PR I would like to make a structural change to the plugin and its components.
Despite this concept where we currently distinguish between the lobby and the arena, e.g. :
/lobby
and/arena
)%missilewars_lobby_gamestate_<lobby-name>%
)The "lobby" is meant once as a game object and once as a lobby region, which leads to this kind of inconsistent and confusing spellings.
With this PR a clear difference will be made between the game, its arena and the lobbies. However, this will mainly affect the names and the folder structure (see screenshot) and will therefore not have any major impact on functionality. It's just a formality! This is a more accurate realization of the actual module system of MissileWars.