Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Edge Orientation improvements #47

Open
agitter opened this issue Jul 13, 2021 · 3 comments
Open

Maximum Edge Orientation improvements #47

agitter opened this issue Jul 13, 2021 · 3 comments

Comments

@agitter
Copy link
Collaborator

agitter commented Jul 13, 2021

#34 added initial support for the Maximum Edge Orientation pathway reconstruction algorithm. After adding support for partially directed input and output graphs (#28), this algorithm will need to be updated. We also need to document the assumptions that this wrapper makes and the required arguments (#26).

It is also possible to load the MEO paths to rank edges. The SDREM software does this as an extension of the MEO code, but it is not directly supported by MEO yet.

As the MEO maintainer, I should also update its readme to advertise that it is now available (and easy to use) via SPRAS.

@annaritz
Copy link
Contributor

Quick note here - I merged main into the precision-recall branch before I continue working on it, and the Test Docker Wrappers failed during reconstruct with MEO. I suspect this may be due to some input file formatting issues since it's running on a netpath pathway. I haven't looked closely at it yet. See Pull Request #36 for the full output.

Screen Shot 2021-07-15 at 12 53 39 PM

@agitter agitter mentioned this issue Jul 22, 2021
7 tasks
@agitter
Copy link
Collaborator Author

agitter commented Jul 30, 2021

I'm noting that MEO may have problems with pairs of directed edges (u,v) and (v,u). That will need to be explored further once SPRAS supports partially directed input networks.

@agitter
Copy link
Collaborator Author

agitter commented Dec 3, 2023

MEO also crashed with undirected self-edges when I was testing a version of the EGFR dataset. I removed those edges from our example input data those in #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants