Removed an else clause to fix Chrome touch issue #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! This fix Issue #18. |
|
But it not work with opera and ie10. |
Closed
|
Fixed, as in #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This for me fixes Issue #16. The else clause was causing the tooltip event handler to never be fired, because window.Touch now returns true even on a machine where you only have a mouse. Removing it means that mouse events now work on desktop chrome as well as touch events. I sadly don't have a chromebook with touch to test whether it works fine using both a mouse and touch at the same time, but I think it should be fine.