Update to new fork #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit global definition
default scaleShowLabels value for Line and Bar is true in js file, but it is false in document page. Correct document page to match the value to reduce the confuse
Correct default scaleShowLabels value in document
Challenge post are running a competition and offering some great prizes. Details are in the readme.
spelling changed for competition
Keeps Chart as a global when included inside wrapper IIFE
Using a framework that joins several js files, will cause errors, since this file isn't properly closed
The config.datasetStroke option for Line and Radar charts was being ignored, I fixed that and also cached datasetStrokeWidth to a local variable before entering the foor loop as the value won't change inside the loop.
* 'patch-1' of https://github.com/ryanponce/Chart.js: Fix typo in line chart section
* 'patch-1' of https://github.com/jakabfia/Chart.js: Update Chart.js
|
Thanks for your interest in my fork. As I already mentioned in nnnick#356, I'm not going to effectively push any new code fragments to the old core. I'll wait for nnnicks big refactor :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help work with this PR to bring your contributions to chart.js to the latest support "canonical" fork of the project.
As you may know, nnnick from chart.js has disappeared and there are many people still working on the project with their PRs and issues to nnnick being ignored.
Please help by carefully and manually merging your fork with the fulldecent/chart.js MASTER branch. At this time we are hoping to collect incremental work (not rewrites) into the fulldecent/chart.js MASTER branch and continue discussion at that project about how to move forward. Progress so far is:
And there is more discussion on the new fork at chartjs#356