Merge pull request #28 from RegestaItalia/major

Major release

docs/setup.md

@@ -27,7 +27,7 @@ To sum up the installation:
 
 - Download the RFC SDK from the SAP® Support Portal (follow the updated link of the note in [this section](https://support.sap.com/en/product/connectors/nwrfcsdk.html?anchorId=section_1291717368))
 
-> **TRM DOESN'T PROVIDE THE REQUIRED SDK, IT CAN AND SHOULD ONLY BE DOWNLOADED FROM OFFICIAL SOURCES**
+> **TRM DOESN'T PROVIDE THE REQUIRED SDK, IT CAN BE DOWNLOADED FROM OFFICIAL SOURCES**
 
 - On Windows
     - Create the folder `C:\nwrfcsdk`
@@ -57,7 +57,7 @@ To sum up the installation:
 
 - Download the RFC SDK from [SAP® Software Download Center](https://support.sap.com/en/my-support/software-downloads.html)
 
-> **TRM DOESN'T PROVIDE THE R3TRANS PROGRAM, IT CAN AND SHOULD ONLY BE DOWNLOADED FROM OFFICIAL SOURCES**
+> **TRM DOESN'T PROVIDE THE R3TRANS PROGRAM, IT CAN BE DOWNLOADED FROM OFFICIAL SOURCES**
 
 - On Windows
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "trm-client",
-  "version": "2.3.1",
+  "version": "3.0.0",
   "description": "TRM (Transport Request Manager) Client",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -39,7 +39,7 @@
     "get-root-path": "^2.0.2",
     "ini": "^4.1.1",
     "semver": "^7.5.4",
-    "trm-core": "^2.2.3",
+    "trm-core": "^3.1.5",
     "trm-registry-types": "^1.0.3",
     "xml2js": "^0.6.2"
   },

src/commands/addRegistry.ts

@@ -1,10 +1,9 @@
+import { Inquirer, Logger } from "trm-core";
 import { RegistryAlias } from "../registryAlias";
-import { ActionArguments, AddRegistryArguments } from "./arguments";
+import { AddRegistryArguments } from "./arguments";
 
-export async function addRegistry(commandArgs: AddRegistryArguments, actionArgs: ActionArguments) {
-    const logger = actionArgs.logger;
-    const inquirer = actionArgs.inquirer;
-    const registryName = commandArgs.registry.trim();
+export async function addRegistry(commandArgs: AddRegistryArguments) {
+    const registryName = commandArgs.registryName.trim();
     const auth = commandArgs.authentication;
     var endpoint = commandArgs.endpoint;
     var oAuth;
@@ -18,24 +17,26 @@ export async function addRegistry(commandArgs: AddRegistryArguments, actionArgs:
             throw new Error(`Invalid authentication JSON object.`);
         }
     }
-    const inq1 = await inquirer.prompt({
+    const inq1 = await Inquirer.prompt({
         type: "input",
         name: "endpoint",
         message: "Registry endpoint",
         default: endpoint,
         when: !endpoint
     });
     endpoint = inq1.endpoint || endpoint;
-    const registry = RegistryAlias.create(registryName, endpoint, oAuth, logger);
+    const registry = RegistryAlias.create(registryName, endpoint, oAuth)
     var pingSuccess = true;
     try{
-        await registry.getRegistry(false, inquirer)
+        const ping = await registry.getRegistry().ping();
+        Logger.registryResponse(ping.wallMessage);
     }catch(e){
+        Logger.error(`Ping to registry "${registryName}" (${endpoint}) failed.`);
         pingSuccess = false;
         throw e;
     }finally{
         if(pingSuccess){
-            logger.success(`Registry added.`);
+            Logger.success(`Registry "${registryName}" added.`);
         }else{
             RegistryAlias.delete(registryName);
         }