refactor: minor improvements

package.json

@@ -68,9 +68,9 @@
     "@typescript-eslint/eslint-plugin": "6.15.0",
     "@typescript-eslint/parser": ">=6.15.0",
     "@typescript-eslint/rule-tester": "6.15.0",
-    "@vitest/ui": "1.0.4",
+    "@vitest/ui": "1.1.0",
     "bun": "1.0.18",
-    "bun-types": "1.0.18-canary.20231218T214637",
+    "bun-types": "1.0.18-canary.20231219T140126",
     "cspell": "8.1.3",
     "dedent": "1.5.1",
     "dprint": "0.44.0",
@@ -85,7 +85,7 @@
     "eslint-plugin-vitest": "0.3.18",
     "fast-equals": "5.0.1",
     "husky": "8.0.3",
-    "knip": "3.8.2",
+    "knip": "3.8.3",
     "markdownlint": "0.32.1",
     "pathe": "1.1.1",
     "publint": "0.2.6",
@@ -105,7 +105,7 @@
     "typedoc-plugin-mermaid": "1.10.0",
     "typedoc-plugin-rename-defaults": "0.7.0",
     "typescript": ">=5.3.3",
-    "vitest": "1.0.4"
+    "vitest": "1.1.0"
   },
   "peerDependencies": {
     "@typescript-eslint/parser": ">=6.15.0",

packages/core/docs/README.md

@@ -30,7 +30,6 @@
 - [ERFunctionComponentFlag](README.md#erfunctioncomponentflag-1)
 - [RE\_COMPONENT\_NAME](README.md#re_component_name)
 - [RE\_HOOK\_NAME](README.md#re_hook_name)
-- [uid](README.md#uid)
 
 ### Functions
 
@@ -68,7 +67,6 @@
 - [isFunctionOfRenderMethod](README.md#isfunctionofrendermethod)
 - [isInsideReactHook](README.md#isinsidereacthook)
 - [isInsideRenderMethod](README.md#isinsiderendermethod)
-- [isMemberExpressionOfReactMember](README.md#ismemberexpressionofreactmember)
 - [isMemo](README.md#ismemo)
 - [isMemoCall](README.md#ismemocall)
 - [isPureComponent](README.md#ispurecomponent)
@@ -240,12 +238,6 @@ ___
 
 • `Const` **RE\_HOOK\_NAME**: `RegExp`
 
-___
-
-### uid
-
-• `Const` **uid**: `default`
-
 ## Functions
 
 ### componentCollector
@@ -914,39 +906,6 @@ It will be removed in the future
 
 ___
 
-### isMemberExpressionOfReactMember
-
-▸ **isMemberExpressionOfReactMember**(`pragmaMemberName`, `memberName`): (`node`: `TSESTree.MemberExpression`, `context`: `RuleContext`, `pragma?`: `string`) => `boolean`
-
-#### Parameters
-
-| Name | Type |
-| :------ | :------ |
-| `pragmaMemberName` | `string` |
-| `memberName` | `string` |
-
-#### Returns
-
-`fn`
-
-A function that checks if a given node is a member expression of a Pragma member.
-
-▸ (`node`, `context`, `pragma?`): `boolean`
-
-##### Parameters
-
-| Name | Type |
-| :------ | :------ |
-| `node` | `TSESTree.MemberExpression` |
-| `context` | `RuleContext` |
-| `pragma?` | `string` |
-
-##### Returns
-
-`boolean`
-
-___
-
 ### isMemo
 
 ▸ **isMemo**(`node`, `context`): `boolean`

packages/core/src/component/component-Identifier.ts

@@ -4,7 +4,7 @@ import { O } from "@eslint-react/tools";
 import type { RuleContext } from "@eslint-react/types";
 import type { TSESTree } from "@typescript-eslint/types";
 
-import { isForwardRefCall, isMemoCall } from "../api";
+import { isForwardRefCall, isMemoCall } from "../react-api";
 
 function isMemoOrForwardRefCall(node: TSESTree.Node, context: RuleContext) {
   if (node.type !== NodeType.CallExpression) {

packages/core/src/component/component-collector-legacy.ts

@@ -3,12 +3,14 @@ import { getPragmaFromContext } from "@eslint-react/jsx";
 import { O } from "@eslint-react/tools";
 import type { RuleContext } from "@eslint-react/types";
 import type { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
+import ShortUniqueId from "short-unique-id";
 import { match, P } from "ts-pattern";
 
-import { uid } from "../utils";
 import type { ERClassComponent } from "./component";
 import { ERClassComponentFlag } from "./component-flag";
 
+const uid = new ShortUniqueId({ length: 10 });
+
 /**
  * Check if a node is a React class component
  * @param node The AST node to check

packages/core/src/component/component-collector.ts

@@ -14,10 +14,10 @@ import { F, MutList, MutRef, O } from "@eslint-react/tools";
 import type { RuleContext } from "@eslint-react/types";
 import { type TSESTree } from "@typescript-eslint/types";
 import type { ESLintUtils } from "@typescript-eslint/utils";
+import ShortUniqueId from "short-unique-id";
 import { match } from "ts-pattern";
 
 import { unsafeIsReactHookCall } from "../hook";
-import { uid } from "../utils";
 import type { ERFunctionComponent } from "./component";
 import { DEFAULT_COMPONENT_COLLECTOR_HINT, ERComponentCollectorHint } from "./component-collector-hint";
 import { ERFunctionComponentFlag } from "./component-flag";
@@ -26,6 +26,8 @@ import { getComponentInitPath, hasCallInInitPath } from "./component-init-path";
 import { getComponentNameFromIdentifier, hasNoneOrValidComponentName } from "./component-name";
 import { isFunctionOfRenderMethod } from "./component-render-method";
 
+const uid = new ShortUniqueId({ length: 10 });
+
 function hasValidHierarchy(node: TSESTreeFunction, context: RuleContext, hint: bigint) {
   if (isChildrenOfCreateElement(node, context) || isFunctionOfRenderMethod(node, context)) {
     return false;

packages/core/src/hook/hook-collector.ts

@@ -1,12 +1,14 @@
 import { getFunctionIdentifier, type TSESTreeFunction } from "@eslint-react/ast";
 import { O } from "@eslint-react/tools";
 import type { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
+import ShortUniqueId from "short-unique-id";
 
-import { uid } from "../utils";
 import type { ERHook } from "./hook";
 import { unsafeIsReactHookCall } from "./hook-call";
 import { isValidReactHookName } from "./hook-name";
 
+const uid = new ShortUniqueId({ length: 10 });
+
 export function hookCollector(): {
   // manually specify the return type here to avoid @typescript-eslint/utils's TS2742 error
   ctx: {

packages/core/src/index.ts

@@ -1,7 +1,6 @@
-export * from "./api";
 export * from "./component";
 export * from "./construction";
 export * from "./hook";
 export * from "./internal";
+export * from "./react-api";
 export * from "./render-prop";
-export * from "./utils";

packages/core/src/internal/index.ts

@@ -1,3 +1,2 @@
 export * from "./analyzer-node";
-export * from "./is-member-expression-of-react-member";
 export * from "./is-react-api";

packages/core/src/api/api.ts → packages/core/src/react-api.ts

@@ -1,7 +1,7 @@
 import type { RuleContext } from "@eslint-react/types";
 import type { TSESTree } from "@typescript-eslint/types";
 
-import { isReactAPI, isReactAPICall } from "../internal";
+import { isReactAPI, isReactAPICall } from "./internal";
 
 // Workaround for @typescript-eslint/utils's TS2742 error.
 type A = (node: TSESTree.Identifier | TSESTree.MemberExpression, context: RuleContext) => boolean;