Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

Fix issues in encrypted chats from profanity to profanity #44

Merged

Conversation

paullouisageneau
Copy link
Contributor

@paullouisageneau paullouisageneau commented Mar 24, 2018

Fixes two issues that prevent from sending encrypted messages from profanity to profanity:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.012% when pulling 6e905e8 on paullouisageneau:fix-profanity-to-profanity into a1c77a8 on ReneVolution:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.012% when pulling 6e905e8 on paullouisageneau:fix-profanity-to-profanity into a1c77a8 on ReneVolution:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.012% when pulling 6e905e8 on paullouisageneau:fix-profanity-to-profanity into a1c77a8 on ReneVolution:master.

@aereaux
Copy link
Contributor

aereaux commented Mar 24, 2018

To test this I should just need to check it out and run install.sh (and then /plugins reload), and then it will overwrite the old version of the plugin, right?

@paullouisageneau
Copy link
Contributor Author

Yes exactly, but you have to specify the plugin name: /plugins reload prof_omemo_plugin.py

@aereaux
Copy link
Contributor

aereaux commented Mar 24, 2018

Doesn't /plugins reload without an argument reload all plugins?

@paullouisageneau
Copy link
Contributor Author

paullouisageneau commented Mar 24, 2018

Oh right, it does, good point!

@aereaux
Copy link
Contributor

aereaux commented Mar 26, 2018

OK, it looks like this does allow my contacts to successfully receive my messages. I have not yet tested the missing resource in jid part yet. Thanks for the fixes.

@paullouisageneau
Copy link
Contributor Author

You're welcome! I'm glad it helped.

@ReneVolution
Copy link
Owner

Thanks @paullouisageneau. It's great to see the community working on this while I can't.
Did you actually test sending messages with special characters like ÖÄÜ or é?

@aereaux
Copy link
Contributor

aereaux commented Apr 15, 2018

@ReneVolution Special characters shouldn't matter, right? Because it's just decoding the b64encoded data?

@ReneVolution
Copy link
Owner

You're right. Merging then.

@ReneVolution ReneVolution merged commit 7c66c0d into ReneVolution:master Apr 16, 2018
@paullouisageneau paullouisageneau deleted the fix-profanity-to-profanity branch April 16, 2018 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants