-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add README and useful bash scripts #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding these to the repository. I think it would be really helpful to other users :)
README.md
Outdated
## download.sh | ||
|
||
This script uses `ffmpeg` to download via RTSP the video and audio from your camera saving it in the MP4 format, the name will start with the `date` of the day (ex. `2022-08-26--22-00-00-capture-0000.mp4`) and a file will be recorded and saved every `$TIME` seconds. | ||
The name of the files starts with a date to make it easier the management of the files, like removing easily all the records of a specific month, day or year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work, does the stream get downloaded until a certain point? and could we do this "indefinitely" until the script is stopped?
Some questions I think that should be answered:
- How do i stop the download of the stream?
- Limits of downloading the RTSP stream?
- Expected file sizes? also stream quality and network requirements / limitations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know exactly the answers to these questions.
To stop the stream the user can just type "Ctrl+C", for the rest I still need to make experiments and activate my camera at home, which will take a long time.
clean_records.sh
Outdated
@@ -0,0 +1,2 @@ | |||
LAST_MONTH=$(date --date='-1 month' +'%Y-%m') | |||
rm "tmp/$LAST_MONTH-"* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could move this script inside the downloads script as a flag instead since the user would probably not always use the tmp
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a separate script because using crontab a user can in parallel run this only script to delete the old files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can achieve the same thing using a flag with the download script, but i think your approach is better since it cannot be accidental when you literally run "clean_records". But I think you still need to be able to delete stuff in a different folder and thus need to accept an argument for a directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Alano Terblanche <[email protected]>
Co-authored-by: Alano Terblanche <[email protected]>
script and README updated |
related ReolinkCameraAPI/reolinkcameraapi.github.io#1