Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter warnings about hardcoded passwords #2087

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gzurowski
Copy link
Member

@gzurowski gzurowski commented Jan 28, 2025

  • Stop using hardcoded passwords in tests. Instead generate a dummy password (using UUIDs) in most tests.
  • In more specific tests that verify authentication, use a valid random password (containing characters, digits and special characters).
  • Add linter ignore annotations to hardcoded passwords that are supposed to fail password rules.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.50%. Comparing base (4ab9230) to head (8016319).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
+ Coverage   66.47%   66.50%   +0.03%     
==========================================
  Files         427      428       +1     
  Lines       23929    23961      +32     
==========================================
+ Hits        15907    15936      +29     
- Misses       8022     8025       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gzurowski gzurowski force-pushed the fix-linter-passwords branch 4 times, most recently from c8d7c67 to 7c8b1af Compare January 28, 2025 14:54
@gzurowski gzurowski force-pushed the fix-linter-passwords branch from 7c8b1af to 8016319 Compare January 28, 2025 15:06
@gzurowski gzurowski changed the title Fix linter passwords chore: Fix linter warnings about hardcoded passwords Jan 28, 2025
@gzurowski gzurowski marked this pull request as ready for review January 28, 2025 15:07
@gzurowski gzurowski requested a review from a team as a code owner January 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant