-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix linter warnings about hardcoded passwords #2087
Open
gzurowski
wants to merge
7
commits into
master
Choose a base branch
from
fix-linter-passwords
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gzurowski
commented
Jan 28, 2025
•
edited
Loading
edited
- Stop using hardcoded passwords in tests. Instead generate a dummy password (using UUIDs) in most tests.
- In more specific tests that verify authentication, use a valid random password (containing characters, digits and special characters).
- Add linter ignore annotations to hardcoded passwords that are supposed to fail password rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 66.47% 66.50% +0.03%
==========================================
Files 427 428 +1
Lines 23929 23961 +32
==========================================
+ Hits 15907 15936 +29
- Misses 8022 8025 +3 ☔ View full report in Codecov by Sentry. |
gzurowski
force-pushed
the
fix-linter-passwords
branch
4 times, most recently
from
January 28, 2025 14:54
c8d7c67
to
7c8b1af
Compare
gzurowski
force-pushed
the
fix-linter-passwords
branch
from
January 28, 2025 15:06
7c8b1af
to
8016319
Compare
Quality Gate passedIssues Measures |
gzurowski
changed the title
Fix linter passwords
chore: Fix linter warnings about hardcoded passwords
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.