Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add serializer for comments in feed #2138

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gzurowski
Copy link
Member

Add an initial implementation of a serializer for comments:

Example:

 {
      "id": 363,
      "content_type": "RHCOMMENTMODEL",
      "content_object": {
        "comment_content_json": {
          "ops": [
            {
              "insert": "Letsfdohsdgfshousfdg oh;\n"
            }
          ]
        },
        "comment_content_type": "QUILL_EDITOR",
        "comment_type": "GENERIC_COMMENT",
        "document_type": "PAPER",
        "hub": {
          "name": "Neuroscience",
          "slug": "neuroscience"
        },
        "id": 80,
        "parent_id": null,
        "thread_id": 80
      }

@gzurowski gzurowski marked this pull request as ready for review February 26, 2025 16:50
@gzurowski gzurowski requested a review from a team as a code owner February 26, 2025 16:50
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.55%. Comparing base (538c7eb) to head (3861704).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
src/feed/serializers.py 84.00% 4 Missing ⚠️
src/feed/signals/comment_signals.py 96.00% 1 Missing ⚠️
src/feed/tasks.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
+ Coverage   67.77%   68.55%   +0.78%     
==========================================
  Files         427      428       +1     
  Lines       23586    23013     -573     
==========================================
- Hits        15985    15777     -208     
+ Misses       7601     7236     -365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants