Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN-5832] feat(cv): ctas #126

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

PaulEntourage
Copy link
Collaborator

No description provided.

@PaulEntourage PaulEntourage force-pushed the feature/EN-5832_cv_calls_to_action branch from b42ab36 to dea22b1 Compare July 6, 2023 14:16
@PaulEntourage PaulEntourage temporarily deployed to entourage-job-front July 6, 2023 14:16 — with GitHub Actions Inactive
@@ -1,10 +1,24 @@
import React from 'react';
import { StyledH6 } from 'src/components/utils/Headings/Headings.styles';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici on peut utiliser les imports relatifs vu qu'on est dans le même contexte et dans le même dossier ;)

@@ -0,0 +1,24 @@
import React from 'react';
import { StyledH5 } from 'src/components/utils/Headings/Headings.styles';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici on peut utiliser les imports relatifs vu qu'on est dans le même contexte et dans le même dossier ;)

}: CVCallToActionsProps) => {
const isDesktop = useIsDesktop();

const openNewsletterModal = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici il faudrait utiliser un useCallback

@PaulEntourage PaulEntourage merged commit 358b4eb into develop Jul 12, 2023
1 of 2 checks passed
@PaulEntourage PaulEntourage deleted the feature/EN-5832_cv_calls_to_action branch July 12, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants