[EN-6274] feat(cv): integration page CV #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emile-bex
reviewed
Jul 26, 2023
.lintstagedrc.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| module.exports = { | |||
| '*.ts?(x)': 'yarn lint:fix', | |||
| '*.ts?(x)': ['yarn tsc-files', 'yarn lint:fix'], | |||
There was a problem hiding this comment.
C'est quoi tsc-files ? Pourquoi on utilise pas le script ts-check ?
package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "lint": "npx eslint src --ext js,jsx,ts,tsx", | |||
| "lint:fix": "npx eslint src --ext js,jsx,ts,tsx --fix", | |||
| "ts-check": "tsc -p tsconfig.json --noEmit", | |||
| "ts-check:hook": "tsc tsconfig.json --noEmit", | |||
There was a problem hiding this comment.
Il n'est pas utilisé ce script si ? Pourquoi il est différent ?
There was a problem hiding this comment.
ca faut le faire sauter
src/components/cv/CVFicheEdition.tsx
Outdated
| @@ -15,7 +16,17 @@ import { Grid, Img } from 'src/components/utils'; | |||
|
|
|||
| import { CV_STATUS } from 'src/constants'; | |||
| import { useMount, usePrevious } from 'src/hooks/utils'; | |||
| import { CVShape } from './CV.shape'; | |||
|
|
|||
| interface VFicheEditionProps { | |||
There was a problem hiding this comment.
Plutôt CVFicheEditionProps non ?
There was a problem hiding this comment.
Ah oui il manque un C :D
| import { findConstantFromValue, sortByOrder } from 'src/utils'; | ||
|
|
||
| export const CVEditCareerPath = ({ ambitions, businessLines, onChange }) => { | ||
| interface CVEditCareerPath { |
There was a problem hiding this comment.
Plutôt CVEditCareerPathProps
PaulEntourage
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
emile-bex
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.