Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Attributes" rule #1486

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

henriquemoody
Copy link
Member

No description provided.

@henriquemoody henriquemoody added this to the 3.0 milestone Dec 11, 2024
@henriquemoody henriquemoody force-pushed the rule/attributes branch 4 times, most recently from 3dae64a to 48d7c33 Compare December 11, 2024 17:22
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (1093ab3) to head (7cec227).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1486      +/-   ##
============================================
+ Coverage     97.34%   97.36%   +0.01%     
- Complexity      960      967       +7     
============================================
  Files           199      200       +1     
  Lines          2337     2354      +17     
============================================
+ Hits           2275     2292      +17     
  Misses           62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquemoody henriquemoody force-pushed the rule/attributes branch 9 times, most recently from 5e98c3f to 5c26b51 Compare December 13, 2024 02:33
@henriquemoody henriquemoody marked this pull request as ready for review December 13, 2024 02:33
@henriquemoody henriquemoody force-pushed the rule/attributes branch 4 times, most recently from eab4656 to c717898 Compare December 13, 2024 02:47
With this change, any rule can be used as a PHP attribute. I have wanted
to implement this feature for a while, as it allows you to bind the
validation to a specific property and just validate the object
afterwards.
@henriquemoody henriquemoody merged commit 7cec227 into Respect:main Dec 13, 2024
8 checks passed
@henriquemoody henriquemoody deleted the rule/attributes branch December 13, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant