Improve how we handle results to show messages #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, it will be easier to look for those tests, and the root directory will be cleaner.
With the "exceptionAll()" function, we can then have the single message, the full message, and the messages as an array. That makes it harder to get those bugs back.
The name "subsequent" better represents those results. What I would consider a "sibling" would be another child from the same result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
============================================
+ Coverage 97.24% 97.34% +0.10%
- Complexity 953 958 +5
============================================
Files 199 199
Lines 2319 2334 +15
============================================
+ Hits 2255 2272 +17
+ Misses 64 62 -2 ☔ View full report in Codecov by Sentry. |
henriquemoody
force-pushed
the
core/messages
branch
from
cc4b37e to
f66961b
Compare
The way we display messages could have been better, and it took me a while to realise that to make it better, I would need to handle the siblings of a result before deciding whether we should render it. Another issue was that rules like Key and Property had to create a "dumb" parent just so we would display the messages correctly, and in some cases, that wasn't even enough. This commit introduces quite a few changes to how the library works, making the messages much more straightforward.
henriquemoody
force-pushed
the
core/messages
branch
from
f66961b to
82cb05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we display messages could have been better, and it took me a while to realise that to make it better, I would need to handle the siblings of a result before deciding whether we should render it.
Another issue was that rules like Key and Property had to create a "dumb" parent just so we would display the messages correctly, and in some cases, that wasn't even enough.
This commit introduces quite a few changes to how the library works, making the messages much more straightforward.