-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 2497: suspend account #2702
Conversation
Thanks for the PR @ddhuy ! We would still need some tests around this to be sure we're not breaking anything critical with these changes. Would you please include the following test cases:
Looking forward to reviewing once these are in place! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some regression tests against this
@gsaslis I have added regression tests as your suggestion. Please help verify them again. Moving to CLOSED test is not added because we have issue with closing account and I already created a new issue for this. So this test will be added according to the fix of it |
…into issue_2497_ddhuy
This PR is so far out of date with master. So I create a new PR 2904 one. |
thanks @ddhuy ! |
We can now suspend an account, all of its DIDs are prevented to call. Sub-accounts cannot log-in also.