Review changes

pyreindexer/lib/include/queryresults_wrapper.h

@@ -52,10 +52,8 @@ class QueryResultsWrapper {
 
 	void FetchResults() {
 		assert(wrap_);
+		// when results are fetched iterator closes and frees a memory of results buffer of Reindexer
 		++it_;
-		if (it_ == qres_.end()) {
-			it_ = qres_.begin();
-		}
 	}
 
 	const std::vector<reindexer::AggregationResult>& GetAggregationResults() & { return qres_.GetAggregationResults(); }

pyreindexer/lib/src/rawpyreindexer.cc

@@ -227,8 +227,7 @@ static PyObject* itemModify(PyObject* self, PyObject* args, ItemModifyMode mode)
 
 	Py_DECREF(itemDefDict);
 
-	char* json = const_cast<char*>(wrSer.c_str());
-	err = item.Unsafe().FromJSON(json, 0, mode == ModeDelete);
+	err = item.Unsafe().FromJSON(wrSer.c_str(), 0, mode == ModeDelete);
 	if (!err.ok()) {
 		Py_XDECREF(preceptsList);
 
@@ -246,7 +245,7 @@ static PyObject* itemModify(PyObject* self, PyObject* args, ItemModifyMode mode)
 			return pyErr(err);
 		}
 
-		item.SetPrecepts(itemPrecepts);
+		item.SetPrecepts(itemPrecepts); // ToDo after migrate on v.4, do std::move
 	}
 
 	Py_XDECREF(preceptsList);
@@ -515,8 +514,7 @@ static PyObject* itemModifyTransaction(PyObject* self, PyObject* args, ItemModif
 
 	Py_DECREF(itemDefDict);
 
-	char* json = const_cast<char*>(wrSer.c_str());
-	err = item.Unsafe().FromJSON(json, 0, mode == ModeDelete);
+	err = item.Unsafe().FromJSON(wrSer.c_str(), 0, mode == ModeDelete);
 	if (!err.ok()) {
 		Py_XDECREF(preceptsList);
 
@@ -534,7 +532,7 @@ static PyObject* itemModifyTransaction(PyObject* self, PyObject* args, ItemModif
 			return pyErr(err);
 		}
 
-		item.SetPrecepts(itemPrecepts);
+		item.SetPrecepts(itemPrecepts); // ToDo after migrate on v.4, do std::move
 	}
 
 	Py_XDECREF(preceptsList);
@@ -566,7 +564,6 @@ static PyObject* CommitTransaction(PyObject* self, PyObject* args) {
 
 	auto transaction = getWrapper<TransactionWrapper>(transactionWrapperAddr);
 
-	assert((StopTransactionMode::Commit == stopMode) || (StopTransactionMode::Rollback == stopMode));
 	size_t count = 0;
 	Error err = transaction->Commit(count);
 
@@ -583,7 +580,6 @@ static PyObject* RollbackTransaction(PyObject* self, PyObject* args) {
 
 	auto transaction = getWrapper<TransactionWrapper>(transactionWrapperAddr);
 
-	assert((StopTransactionMode::Commit == stopMode) || (StopTransactionMode::Rollback == stopMode));
 	Error err = transaction->Rollback();
 
 	wrapperDelete<TransactionWrapper>(transactionWrapperAddr);

setup.py

@@ -52,7 +52,7 @@ def build_cmake(self, ext):
 
 
 setup(name=PACKAGE_NAME,
-      version='0.2.44',
+      version='0.2.45',
       description='A connector that allows to interact with Reindexer',
       author='Igor Tulmentyev',
       author_email='[email protected]',