#207: Calendars Page #286
Open
#207: Calendars Page #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-file-which-causes-error-on-windows this file fails to add on window env
…-for-widows-env fix npm scripts for Windows env by adding cross-env package
Restuta
reviewed
May 28, 2017
src/client/calendar/Calendars.scss
Outdated
| text-align: center; | ||
| margin-right: 0px; | ||
| border: 1px solid #aaa; | ||
| padding: 0 20px; |
There was a problem hiding this comment.
I don't use "px" in CSS, if you look closer to other files they all use "rems". For convenience there is a helper called pxToRem using which you can specify pixels. When you shrink to mobile view I change base from 8px to 7px, that allows everything to progressively shrink.
There was a problem hiding this comment.
@Restuta Done
Restuta
reviewed
May 28, 2017
src/client/calendar/Calendars.jsx
Outdated
| @@ -10,7 +10,10 @@ class Calendars extends Component { | |||
|
|
|||
| const calendarsComponent = Object.keys(calendars) | |||
| .map(k => <li key={k}> | |||
There was a problem hiding this comment.
I'd use x in place of k or key if you want to be explicit
There was a problem hiding this comment.
@Restuta Done
|
@Restuta what else need to be done here? |
|
Conflicts and overall it’s not “production ready”, design is not great haven’t tested if it’s responsive, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype
This implements
/calendarsroute and closes #207