Skip to content

Conversation

@timtheguy-bs
Copy link
Contributor

This pull request updates the lower bound of atOrAbove to 0.7.30 for CVE-2022-25927.

Rationale:

Currently, all versions of ua-parser-js are flagged for CVE-2022-25927 for any version before 0.7.33. This is the correct behavior if you only consider the GHSA (GHSA-fhg7-m89q-25r3), where we see:

Affected Versions:
All versions of the library prior to version 0.7.33 / 1.0.33.

However, according to the entry in NVD (https://nvd.nist.gov/vuln/detail/cve-2022-25927):

Versions of the package ua-parser-js from 0.7.30 and before 0.7.33, from 0.8.1 and before 1.0.33 are vulnerable to Regular Expression Denial of Service (ReDoS) via the trim() function.

I investigated the discrepancy and can see that in version 0.7.30 of ua-parser-js, the code vulnerable to ReDoS was introduced: faisalman/ua-parser-js@336ce2b

The fix was committed in version 0.7.33: faisalman/ua-parser-js@a6140a1

Therefore, I believe we can confidently use the version range described in the NVD advisory.

@eoftedal
Copy link
Contributor

Thanks! Did you also submit a PR for GHSA-fhg7-m89q-25r3 ?

@timtheguy-bs timtheguy-bs force-pushed the add-lower-limit-cve-2022-25927 branch 2 times, most recently from d718562 to 91a7c3e Compare October 16, 2025 12:27
@timtheguy-bs timtheguy-bs force-pushed the add-lower-limit-cve-2022-25927 branch from 91a7c3e to 25e8823 Compare October 16, 2025 12:29
@timtheguy-bs
Copy link
Contributor Author

I've updated my commit to be Verified, and also submitted a PR for the GHSA: github/advisory-database#6325. Good call!

@eoftedal eoftedal merged commit 9864a66 into RetireJS:master Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants