Correct lower limit for CVE-2022-25927 #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the lower bound of
atOrAboveto0.7.30for CVE-2022-25927.Rationale:
Currently, all versions of
ua-parser-jsare flagged for CVE-2022-25927 for any version before 0.7.33. This is the correct behavior if you only consider the GHSA (GHSA-fhg7-m89q-25r3), where we see:However, according to the entry in NVD (https://nvd.nist.gov/vuln/detail/cve-2022-25927):
I investigated the discrepancy and can see that in version 0.7.30 of
ua-parser-js, the code vulnerable to ReDoS was introduced: faisalman/ua-parser-js@336ce2bThe fix was committed in version 0.7.33: faisalman/ua-parser-js@a6140a1
Therefore, I believe we can confidently use the version range described in the NVD advisory.