feat(api): add IconURL to API_GetConsoleIDs #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR into RAWeb! Since this is an API update, would you also be willing to open an accompanying PR in https://github.com/RetroAchievements/api-docs for the page associated with this endpoint? It can be found at https://api-docs.retroachievements.org/v1/get-console-ids.html. |
luchaos
reviewed
Feb 25, 2024
wescopeland
changed the title
|
@wescopeland Just created a PR updating the API doc |
wescopeland
reviewed
Feb 26, 2024
Co-authored-by: Wes Copeland <[email protected]>
wescopeland
reviewed
Feb 26, 2024
wescopeland
approved these changes
Feb 26, 2024
Jamiras
reviewed
Feb 26, 2024
Jamiras
approved these changes
Feb 26, 2024
|
@wescopeland @Jamiras @luchaos Any ETA about when this will be merged? I'm not authorized to do it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the console's icon path to the response in order to get from the API the same icon displayed in the "Games" menu