Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(leaderboardinfo): don't ignore display names for local user #3192

Conversation

wescopeland
Copy link
Member

Resolves https://discord.com/channels/310192285306454017/859938399468388362/1337200540043710506.

Currently, the leaderboardinfo page does not detect if the authenticated user is using a custom display name. As a result, it doesn't highlight their score and still shows the CTA telling them to consider participating.

Before
Screenshot 2025-02-07 at 5 41 29 PM

Screenshot 2025-02-07 at 5 41 32 PM

After
Screenshot 2025-02-07 at 5 41 17 PM

Screenshot 2025-02-07 at 5 41 21 PM

@wescopeland wescopeland merged commit b99e37e into RetroAchievements:master Feb 7, 2025
9 checks passed
@wescopeland wescopeland deleted the leaderboard-display-name-fix branch February 7, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant